Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default github issue templates under ros2 org. #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fujitatomoya
Copy link

Copy link
Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to get more feedback here as default issue templates under ros2 org. any comments are welcome! thanks in advance.

CC: @clalancette @kscottz

.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Show resolved Hide resolved
Copy link
Collaborator

@kscottz kscottz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tomoya,

This is certainly better than what we presently have so I'll approve it. I've made a couple of suggestions comments. We may want to discuss further at the PMC meeting next week.

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Show resolved Hide resolved
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like the idea.

However, I do think we should strive to have a minimum of fields here. The more we have, the more confusing it is for people to report bugs (and a number of things will be filled in incorrectly anyway). I've left a couple of comments inline towards making this simpler.

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@fujitatomoya
Copy link
Author

@clalancette can you review this? i think it is okay to deploy, and if any repositories have their own templates, this will not affect them. IMO, it is hard to complete the perfect format, so would like to get some feedback from time to time.

fujitatomoya and others added 3 commits November 22, 2024 09:01
Signed-off-by: Tomoya.Fujita <[email protected]>
Co-authored-by: Peter Borkuti <[email protected]>
Signed-off-by: Tomoya.Fujita <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/org-issue-template branch from 50b7578 to 3f671c1 Compare November 22, 2024 17:03
@fujitatomoya
Copy link
Author

@clalancette is there anything i can do on my side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make issue templates consistent across repositories.
3 participants